aboutsummaryrefslogtreecommitdiff
path: root/drivers/staging
AgeCommit message (Collapse)AuthorFilesLines
2026-01-27staging: rtl8723bs: replace uint with unsigned intOmer El Idrissi1-1/+1
Replace non-standard uint type with explicit unsigned int to improve readability and conform to kernel coding style. Signed-off-by: Omer El Idrissi <omer.e.idrissi@gmail.com> Link: https://patch.msgid.link/20260125185956.13882-1-omer.e.idrissi@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-27staging: greybus: remove completed GPIO conversion task from TODOArchit Anant1-3/+0
The task to convert the Greybus subsystem to the GPIO descriptor interface has been completed. A grep of the directory confirms that no consumer drivers include <linux/gpio.h> or use the legacy integer based GPIO API (gpio_request, gpio_set_value, etc). Remove the stale entry from the TODO file. Signed-off-by: Archit Anant <architanant5@gmail.com> Link: https://patch.msgid.link/20260124174149.10314-1-architanant5@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-27staging: rtl8723bs: rename add_RATid to add_ratidEthan Tidmore3-6/+6
Rename add_RATid to add_ratid to align with kernel code style. Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com> Link: https://patch.msgid.link/20260124013350.33769-1-ethantidmore06@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-27staging: axis-fifo: Fix indentationGeet Singhi1-1/+1
Check reported by checkpatch.pl CHECK: Alignment should match open parenthesis Signed-off-by: Geet Singhi <singhigeet1729@gmail.com> Link: https://patch.msgid.link/20260123205905.37717-1-singhigeet1729@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-27staging: most: dim2: replace macro with static functionEthan Tidmore1-5/+7
Replace unsafe macro with function to avoid side effects. Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://patch.msgid.link/20260123191150.3281-1-ethantidmore06@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-27staging: rtl8723bs: fix alignment to match open parenthesisArchit Anant1-11/+11
Align arguments and conditions with the open parenthesis of the preceding line to comply with the Linux kernel coding style. Issue identified by checkpatch.pl. Signed-off-by: Archit Anant <architanant5@gmail.com> Link: https://patch.msgid.link/20260116155750.3173-3-architanant5@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-27staging: rtl8723bs: fix spacing around operatorsArchit Anant1-13/+13
Add missing spaces around mathematical and logical operators (+, -, /, |, ?, :) and remove multiple spaces around operators to comply with the Linux kernel coding style. Issue identified by checkpatch.pl and review feedback. Signed-off-by: Archit Anant <architanant5@gmail.com> Link: https://patch.msgid.link/20260116155750.3173-2-architanant5@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-21media: staging: media: imx6-mipi-csi2: use devm_platform_ioremap_resource() ↵Frank Li1-10/+3
simplify code Use devm_platform_ioremap_resource() simplify code. No functional change. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by: Frank Li <Frank.Li@nxp.com> Link: https://patch.msgid.link/20260116-stage-csi2-cleanup-v2-5-a56e9cb25196@nxp.com Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
2026-01-21media: staging: media: imx6-mipi-csi2: use devm_mutex_init() to simplify codeFrank Li1-5/+4
Use devm_mutex_init() to simplify the code. No functional change. Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by: Frank Li <Frank.Li@nxp.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Link: https://patch.msgid.link/20260116-stage-csi2-cleanup-v2-2-a56e9cb25196@nxp.com Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
2026-01-21media: staging: media: imx6-mipi-csi2: replace spaces with tabs for alignmentFrank Li1-42/+42
Replace spaces with tabs to align register value definitions, making it easier to add new entries and maintain consistent formatting. Also use a space between the type and field in struct csi2_dev. No functional change. Signed-off-by: Frank Li <Frank.Li@nxp.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Link: https://patch.msgid.link/20260116-stage-csi2-cleanup-v2-1-a56e9cb25196@nxp.com Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
2026-01-20kernel.h: drop hex.h and update all hex.h usersRandy Dunlap1-0/+1
Remove <linux/hex.h> from <linux/kernel.h> and update all users/callers of hex.h interfaces to directly #include <linux/hex.h> as part of the process of putting kernel.h on a diet. Removing hex.h from kernel.h means that 36K C source files don't have to pay the price of parsing hex.h for the roughly 120 C source files that need it. This change has been build-tested with allmodconfig on most ARCHes. Also, all users/callers of <linux/hex.h> in the entire source tree have been updated if needed (if not already #included). Link: https://lkml.kernel.org/r/20251215005206.2362276-1-rdunlap@infradead.org Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Yury Norov (NVIDIA) <yury.norov@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2026-01-16staging: rtl8723bs: expand multiple assignment into separate statementsNayana Mariyappa1-1/+2
Split multiple assignments in a single line into separate statements in osdep_service.c to follow kernel coding style. No functional change. Signed-off-by: Nayana Mariyappa <nayana.mariyappa@gmail.com> Link: https://patch.msgid.link/20260116120511.48272-5-nayana.mariyappa@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-16staging: rtl8723bs: add blank lines after declarationsNayana Mariyappa1-0/+1
Added blank lines after variable declarations in osdep_service.c and related files to improve readability and follow kernel coding style. No functional change. Signed-off-by: Nayana Mariyappa <nayana.mariyappa@gmail.com> Link: https://patch.msgid.link/20260116120511.48272-4-nayana.mariyappa@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-16staging: rtl8723bs: remove extra blank linesNayana Mariyappa1-1/+0
Removed unnecessary blank lines in osdep_service.c and related files to follow kernel coding style. No functional change. Signed-off-by: Nayana Mariyappa <nayana.mariyappa@gmail.com> Link: https://patch.msgid.link/20260116120511.48272-3-nayana.mariyappa@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-16staging: rtl8723bs: fix block comment styleNayana Mariyappa1-4/+1
Fixed multi-line block comments in osdep_service.c to follow kernel coding style. Fixing the non-kernel-doc comment has been merged into this patch. No functional change. Signed-off-by: Nayana Mariyappa <nayana.mariyappa@gmail.com> Link: https://patch.msgid.link/20260116120511.48272-2-nayana.mariyappa@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-16staging: rtl8723bs: fix operator and type cast spacingKhushal Chitturi1-39/+50
Fix spacing around operators and type casts in rtw_xmit.c to comply with the kernel coding style. Signed-off-by: Khushal Chitturi <khushalchitturi@gmail.com> Link: https://patch.msgid.link/20260116053052.4198-2-khushalchitturi@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-16staging: rtl8723bs: fix memory leak on failure pathDiksha Kumari1-1/+2
cfg80211_inform_bss_frame() may return NULL on failure. In that case, the allocated buffer 'buf' is not freed and the function returns early, leading to potential memory leak. Fix this by ensuring that 'buf' is freed on both success and failure paths. Signed-off-by: Diksha Kumari <dikshakdevgan@gmail.com> Reviewed-by: Mukesh Kumar Chaurasiya <mkchauras@linux.ibm.com> Link: https://patch.msgid.link/20260113091712.7071-1-dikshakdevgan@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-16staging: rtl8723bs: remove unnecessary blank linesArchitAnant1-5/+1
Remove blank lines before closing braces to comply with the Linux kernel coding style. Issue identified by checkpatch.pl. Signed-off-by: ArchitAnant <architanant5@gmail.com> Link: https://patch.msgid.link/20260114094949.14825-3-architanant5@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-16staging: rtl8723bs: core/rtw_mlme_ext.c: flatten indentation with early loop ↵William Hansen-Baird1-30/+31
continue in OnAssocReq() Replace large if (memcmp(p+2, WMM_IE, 6)) inside the for (;;) loop, which ends with a break, with an early continue. This reduces deep nesting and is purely stylistic. Signed-off-by: William Hansen-Baird <william.hansen.baird@gmail.com> Link: https://patch.msgid.link/20260113211433.89512-2-william.hansen.baird@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-16staging: rtl8723bs: core/rtw_mlme_ext.c: flatten control flow in OnAssocReq()William Hansen-Baird1-30/+29
Rewrite if-else construct with an early exit to reduce indentation, and make the execution clearer. Signed-off-by: William Hansen-Baird <william.hansen.baird@gmail.com> Link: https://patch.msgid.link/20260113211433.89512-1-william.hansen.baird@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-16staging: rtl8723bs: Rename supportRate and SupportRateNum to snake_caseMatous Jarolim1-11/+11
renamed variables supportRate and supportRateNum to support_rate and support_rate_num to adhere to the linux kernel coding style which mandates snake_case for variable names. This fixes the following checkpatch.pl warning: CHECK: Avoid CamelCase: <supportRate> CHECK: Avoid CamelCase: <supportRateNum> Signed-off-by: Matous Jarolim <matous.jarolim.lkml@gmail.com> Link: https://patch.msgid.link/20260113170346.557634-1-matous.jarolim.lkml@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-16staging: rtl8723bs: Fix block comment alignment in HalHWImg8723B_RF.cMahad Ibrahim1-13/+14
Fix checkpatch.pl warnings regarding block comment alignment. Adhere to kernel coding style by fixing block comments. Signed-off-by: Mahad Ibrahim <mahad.ibrahim.dev@gmail.com> Link: https://patch.msgid.link/20260112174227.14922-8-mahad.ibrahim.dev@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-16staging: rtl8723bs: Fix spacing coding style issues in HalHWImg8723B_BB.cMahad Ibrahim1-17/+17
Fix checkpatch.pl checks regarding "spaces preferred around that" operator. Adhere to kernel coding standards by adding spaces around arithmetic and bitwise operations. Signed-off-by: Mahad Ibrahim <mahad.ibrahim.dev@gmail.com> Link: https://patch.msgid.link/20260112174227.14922-6-mahad.ibrahim.dev@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-16staging: rtl8723bs: Fix block comment alignment in HalHWImg8723B_BB.cMahad Ibrahim1-16/+18
Fix checkpatch.pl warnings regarding block comment alignment. The warnings were: "Block comments should align the * on each line". This patch aligns the asterisks in the block comments so they adhere to the kernel coding style. Signed-off-by: Mahad Ibrahim <mahad.ibrahim.dev@gmail.com> Link: https://patch.msgid.link/20260112174227.14922-5-mahad.ibrahim.dev@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-16staging: rtl8723bs: Fix spaces around operator checks in HalHWImg8723B_MAC.cMahad Ibrahim1-7/+7
Fix checkpatch.pl checks in HalHWImg8723B_MAC.c regarding: -Spaces preferred around that operator Adhere to kernel coding style by adding spaces around operators. Signed-off-by: Mahad Ibrahim <mahad.ibrahim.dev@gmail.com> Link: https://patch.msgid.link/20260112174227.14922-3-mahad.ibrahim.dev@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-16staging: rtl8723bs: Fix block comment alignment in HalHWImg8723B_MAC.cMahad Ibrahim1-6/+6
Fix checkpatch warnings regarding block comment alignment. The warnings were: "Block comments should align the * on each line". This patch aligns the asterisks in the block comments to match the kernel coding style. Signed-off-by: Mahad Ibrahim <mahad.ibrahim.dev@gmail.com> Link: https://patch.msgid.link/20260112174227.14922-2-mahad.ibrahim.dev@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-16staging: greybus: add WQ_PERCPU to alloc_workqueue usersMarco Crivellari1-1/+1
This continues the effort to refactor workqueue APIs, which began with the introduction of new workqueues and a new alloc_workqueue flag in: commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq") commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag") The refactoring is going to alter the default behavior of alloc_workqueue() to be unbound by default. With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND), any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND must now use WQ_PERCPU. For more details see the Link tag below. In order to keep alloc_workqueue() behavior identical, explicitly request WQ_PERCPU. Link: https://lore.kernel.org/all/20250221112003.1dSuoGyc@linutronix.de/ Suggested-by: Tejun Heo <tj@kernel.org> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com> Link: https://patch.msgid.link/20260113135737.190636-1-marco.crivellari@suse.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-16staging: rtl8723bs: remove unnecessary else after breakVo Thanh Cong1-16/+16
This patch fixes the checkpatch.pl warning: "WARNING: else is not generally useful after a break or return" In sdio_ops_linux.c, the else blocks after break statements are redundant. Removing them reduces indentation level and improves code readability. Signed-off-by: Vo Thanh Cong <thanhcongvo079@gmail.com> Link: https://patch.msgid.link/20260113103738.207570-1-thanhcongvo079@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-15staging: rtl8723bs: core: Use new AES library APIEric Biggers1-10/+10
Switch from the old AES library functions (which use struct crypto_aes_ctx) to the new ones (which use struct aes_enckey). This eliminates the unnecessary computation and caching of the decryption round keys. The new AES en/decryption functions are also much faster and use AES instructions when supported by the CPU. Note that in addition to the change in the key preparation function and the key struct type itself, the change in the type of the key struct results in aes_encrypt() (which is temporarily a type-generic macro) calling the new encryption function rather than the old one. Acked-by: Ard Biesheuvel <ardb@kernel.org> Link: https://lore.kernel.org/r/20260112192035.10427-23-ebiggers@kernel.org Signed-off-by: Eric Biggers <ebiggers@kernel.org>
2026-01-13media: staging/ipu7: Fix the loop bound in l2 table allocBingbu Cao1-1/+1
This patch fixes the incorrect loop bound in alloc_l2_pt(). When initializing L2 page table entries, the loop was incorrectly using ISP_L1PT_PTES instead of ISP_L2PT_PTES though the ISP_L1PT_PTES is equal to ISP_L2PT_PTES. Fixes: 71d81c25683a ("media: staging/ipu7: add IPU7 DMA APIs and MMU mapping") Cc: stable@vger.kernel.org Signed-off-by: Bingbu Cao <bingbu.cao@intel.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
2026-01-13media: staging/ipu7: Update CDPHY register settingsBingbu Cao1-3/+10
Some CPHY settings needs to updated according to the latest guide from SNPS. This patch program 45ohm for tuning resistance to fix CPHY problem and update the ITMINRX and GMODE for CPHY. Cc: Stable@vger.kernel.org Fixes: a516d36bdc3d ("media: staging/ipu7: add IPU7 input system device driver") Signed-off-by: Bingbu Cao <bingbu.cao@intel.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
2026-01-13media: staging/ipu7: Call synchronous RPM suspend in probe failureBingbu Cao1-1/+1
If firmware authentication failed during driver probe, driver call an asynchronous API to suspend the psys device but the bus device will be removed soon, thus runtime PM of bus device will be disabled soon, that will cancel the suspend request, so use synchronous suspend to make sure the runtime suspend before disabling its RPM. IPU7 hardware has constraints that the PSYS device must be powered off before ISYS, otherwise it will cause machine check error. Cc: Stable@vger.kernel.org Fixes: b7fe4c0019b1 ("media: staging/ipu7: add Intel IPU7 PCI device driver") Signed-off-by: Bingbu Cao <bingbu.cao@intel.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
2026-01-13media: staging/ipu7: Ignore interrupts when device is suspendedBingbu Cao2-1/+20
IPU7 devices have shared interrupts with others. In some case when IPU7 device is suspended, driver get unexpected interrupt and invalid irq status 0xffffffff from ISR_STATUS and PB LOCAL_STATUS registers as interrupt is triggered from other device on shared irq line. In order to avoid this issue use pm_runtime_get_if_active() to check if IPU7 device is resumed, ignore the invalid irq status and use synchronize_irq() in suspend. Cc: Stable@vger.kernel.org Fixes: b7fe4c0019b1 ("media: staging/ipu7: add Intel IPU7 PCI device driver") Signed-off-by: Bingbu Cao <bingbu.cao@intel.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
2026-01-14staging: media: atomisp: fix trailing statementArjun Changla1-1/+2
Fix checkpatch error "trailing statements should be on next line" by moving the return statement to a new line. Signed-off-by: Arjun Changla <arjunchangla7@gmail.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
2026-01-14media: staging: atomisp: remove redundant OOM error messagesZixuan Dong1-4/+1
The memory allocation functions (kvzalloc) already emit a stack dump on failure when GFP_KERNEL is used. Printing an extra error message is redundant and increases code size. This resolves the checkpatch warnings: WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Zixuan Dong <dbeidachazi@foxmail.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
2026-01-13host1x: Make remove callback return voidUwe Kleine-König1-3/+1
The return value of struct device_driver::remove is ignored by the core (see device_remove() in drivers/base/dd.c). So it doesn't make sense to let the host1x remove callback return an int just to ignore it later. So make the callback return void. All current implementors return 0, so they are easily converted. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com> # tegra20 tegra-video Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Signed-off-by: Thierry Reding <treding@nvidia.com> Link: https://patch.msgid.link/d364fd4ec043d36ee12e46eaef98c57658884f63.1765355236.git.u.kleine-koenig@baylibre.com
2026-01-13staging: media: tegra-video: move tegra20_vip_soc declaration to vip.hSun Jian2-4/+4
tegra20_vip_soc is shared across translation units but is currently declared via an extern in vip.c. Move the declaration to vip.h so users get it via the header and we avoid extern declarations in .c files, matching the pattern already used by tegra20_vi_soc and tegra210_vi_soc. Suggested-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Signed-off-by: Sun Jian <sun.jian.kdev@gmail.com> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
2026-01-13staging: media: tegra-video: move tegra210_csi_soc declaration to csi.hSun Jian2-4/+4
Sparse warns that tegra210_csi_soc is not declared in tegra210.c. The symbol is referenced from csi.c, so it must remain global. Move the declaration to csi.h so users see it via the header and avoid extern declarations in .c files. SPARSE: drivers/staging/media/tegra-video/tegra210.c:1214:28: warning: symbol 'tegra210_csi_soc' was not declared. Should it be static? No functional change intended. Suggested-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Signed-off-by: Sun Jian <sun.jian.kdev@gmail.com> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
2026-01-13staging: media: av7110: use usleep_range in sp8870.cPreyas Sharma1-1/+1
Use usleep_range instead of udelay to fix checkpatch warning. Signed-off-by: Preyas Sharma <preyas17@zohomail.in> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org> [hverkuil: added commit message]
2026-01-13staging: media: av7110: use usleep_range in av7110_hw.cPreyas Sharma1-10/+10
Use usleep_range instead of msleep to fix checkpatch warnings. Signed-off-by: Preyas Sharma <preyas17@zohomail.in> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org> [hverkuil: added commit message]
2026-01-13media: tegra-video: Fix memory leak in __tegra_channel_try_format()Zilin Guan1-5/+8
The state object allocated by __v4l2_subdev_state_alloc() must be freed with __v4l2_subdev_state_free() when it is no longer needed. In __tegra_channel_try_format(), two error paths return directly after v4l2_subdev_call() fails, without freeing the allocated 'sd_state' object. This violates the requirement and causes a memory leak. Fix this by introducing a cleanup label and using goto statements in the error paths to ensure that __v4l2_subdev_state_free() is always called before the function returns. Fixes: 56f64b82356b7 ("media: tegra-video: Use zero crop settings if subdev has no get_selection") Fixes: 1ebaeb09830f3 ("media: tegra-video: Add support for external sensor capture") Cc: stable@vger.kernel.org Signed-off-by: Zilin Guan <zilin@seu.edu.cn> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
2026-01-11staging: iio: adt7316: modernize power managementMichael Harris4-11/+5
Replaced use of deprecated function SIMPLE_DEV_PM_OPS() with EXPORT_GPL_SIMPLE_DEV_PM_OPS(). Removed PM preprocessor conditions with usage of pm_sleep_ptr(). Signed-off-by: Michael Harris <michaelharriscode@gmail.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
2026-01-11staging: greybus: lights: avoid NULL derefChaitanya Mishra1-2/+6
gb_lights_light_config() stores channel_count before allocating the channels array. If kcalloc() fails, gb_lights_release() iterates the non-zero count and dereferences light->channels, which is NULL. Allocate channels first and only then publish channels_count so the cleanup path can't walk a NULL pointer. Fixes: 2870b52bae4c ("greybus: lights: add lights implementation") Link: https://lore.kernel.org/all/20260108103700.15384-1-chaitanyamishra.ai@gmail.com/ Reviewed-by: Rui Miguel Silva <rui.silva@linaro.org> Signed-off-by: Chaitanya Mishra <chaitanyamishra.ai@gmail.com> Link: https://patch.msgid.link/20260108151254.81553-1-chaitanyamishra.ai@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-11staging: rtl8723bs: fix spacing around arithmetic operatorsPhilip Thayer1-1/+1
Fixed coding style checks where spaces were missing around subtraction and addition operators in rtw_cmd.c. This aligns with the Linux Kernel coding style standards. Signed-off-by: Philip Thayer <thayerscirez@gmail.com> Link: https://patch.msgid.link/20260105194226.57035-2-thayerscirez@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-11staging: greybus: arche-platform: fix spelling mistake in commentHolden Hsu1-1/+1
Fix 'premits' -> 'permits' in a comment to improve code readability. Signed-off-by: Holden Hsu <holden_hsu@163.com> Link: https://patch.msgid.link/20260105104505.8120-3-holden_hsu@163.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-11staging: greybus: arche-platform: clarify TODO commentHolden Hsu1-1/+1
The TODO comment 'sequence ??' is unclear and provides little context about what needs to be implemented. Replace it with 'TODO: define shutdown sequence' to better describe the required implementation. Signed-off-by: Holden Hsu <holden_hsu@163.com> Link: https://patch.msgid.link/20260105104505.8120-2-holden_hsu@163.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-11staging: axis-fifo: Clean up register and mask definitionsOvidiu Panait1-27/+25
Improve readability and consistency of hardware register definitions: - Remove unnecessary leading zeros from register offset values - Use BIT() macro for single-bit interrupt mask definitions - Align values and comments for better readability No functional change. Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com> Link: https://patch.msgid.link/20251227212640.3321310-9-ovidiu.panait.oss@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-11staging: axis-fifo: Remove redundant commentsOvidiu Panait1-95/+10
Drop banner-style section header comments and also remove comments around self-explanatory code to reduce clutter and improve readability. No functional changes. Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com> Link: https://patch.msgid.link/20251227212640.3321310-8-ovidiu.panait.oss@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-11staging: axis-fifo: Remove noisy error messages for user errorsOvidiu Panait1-15/+2
Remove dev_err() calls for conditions caused by invalid userspace input. Logging them clutters the kernel log, especially if userspace repeatedly makes invalid calls. Also, consolidate the write validation checks into a single condition. Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com> Link: https://patch.msgid.link/20251227212640.3321310-7-ovidiu.panait.oss@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-11staging: axis-fifo: Remove unnecessary zero-length packet checkOvidiu Panait1-5/+0
Remove the check for zero-length packets as this condition cannot occur during normal operation. According to the Xilinx AXI4-Stream FIFO Product Guide (PG080), in the Receive Length Register (RLR) description: "The smallest packet that can be received is 1 byte." A zero-length packet would indicate a bug in the IP core itself. Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com> Link: https://patch.msgid.link/20251227212640.3321310-6-ovidiu.panait.oss@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>